-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: LG-12534 FSM clean up part 1 #11578
Draft
jennyverdeyen
wants to merge
9
commits into
main
Choose a base branch
from
jverdeyen/LG-12534-FSM-clean-up
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file removal is a long time coming! Excited to see it happening.
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
December 3, 2024 22:56
f9d621b
to
7174c83
Compare
jennyverdeyen
changed the title
DRAFT: LG-12534 FSM clean up
DRAFT: LG-12534 FSM clean up part 1
Dec 6, 2024
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
2 times, most recently
from
December 17, 2024 15:39
0aac202
to
b8e2b3b
Compare
…on controller changelog: Internal, In-person proofing, cleaning up unused FSM code
…s breaking after removing the dynamic FSM /:step route
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
December 17, 2024 15:41
b8e2b3b
to
2162849
Compare
changelog: Internal, In-person proofing, Move STEP_INDICATOR_STEP constants out of InPersonFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.